feat(models): add shared Content interface#2695
Merged
baywet merged 8 commits intomicrosoft:mainfrom Jan 21, 2026
Merged
Conversation
baywet
previously approved these changes
Jan 21, 2026
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
A couple of minor suggestions
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
Contributor
Author
|
@baywet I'm sure that you already know but the tests are failing on Windows due to differences in newline formats, specifically between CRLF and LF |
baywet
previously approved these changes
Jan 21, 2026
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Member
|
@mdaneri do you mean the unit tests? or a formatting issue with the source code? |
Contributor
Author
xunit tests 5 of 6 of them are failing on windows |
Contributor
Author
|
for example, |
Contributor
Author
|
I think it's an issue with my environment I force windows to use \n only not \r\n |
baywet
reviewed
Jan 21, 2026
src/Microsoft.OpenApi/Models/Interfaces/IOpenApiContentElement.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
baywet
previously approved these changes
Jan 21, 2026
Member
|
@mdaneri the public API export needs to be refreshed, would you mind pushing that latest change please? |
auto-merge was automatically disabled
January 21, 2026 16:16
Head branch was pushed to by a user without write access
baywet
approved these changes
Jan 21, 2026
baywet
added a commit
that referenced
this pull request
Jan 21, 2026
feat(models): add shared Content interface * Update src/Microsoft.OpenApi/Models/Interfaces/IOpenApiContentElement.cs Co-authored-by: Vincent Biret <vincentbiret@hotmail.com> * Update src/Microsoft.OpenApi/Models/Interfaces/IOpenApiContentElement.cs Co-authored-by: Vincent Biret <vincentbiret@hotmail.com> * Update src/Microsoft.OpenApi/Models/OpenApiHeader.cs Co-authored-by: Vincent Biret <vincentbiret@hotmail.com> * Update src/Microsoft.OpenApi/Models/OpenApiResponse.cs Co-authored-by: Vincent Biret <vincentbiret@hotmail.com> * Remove inheritance from IOpenApiReadOnlyContentElement revert commit 7758a81 * Update src/Microsoft.OpenApi/Models/Interfaces/IOpenApiContentElement.cs Co-authored-by: Vincent Biret <vincentbiret@hotmail.com> * test(publicapi): approve content interface surface --------- Co-authored-by: Vincent Biret <vincentbiret@hotmail.com> Signed-off-by: Vincent Biret <vibiret@microsoft.com>
This was referenced Jan 23, 2026
Merged
This was referenced Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Introduce a shared abstraction for OpenAPI elements that expose a
Contentmap, enabling generic helpers and reducing duplication across the model surface.Type of Change
Related Issue(s)
Fixes #2677
Changes Made
IOpenApiContentElement/IOpenApiReadOnlyContentElementto represent the sharedContentcapabilityIOpenApiResponse,IOpenApiRequestBody,IOpenApiParameter, andIOpenApiHeaderto inherit the shared interfaceTesting
Checklist
Versions applicability
Additional Notes
None